Good First Commit

Archives
Subscribe
August 31, 2020

Good First Commit: Week #9 [Shopify, Google, Executablebooks, Grommet]

Hello! Here’s your list of issues for this week.


Shopify

  • Title: Remove back-ticks from output strings

  • Description: Remove back-ticks from output strings, especially if the end-user is expected to reproduce on the command line, as instructed by a help output. This should be attempted once PR #587 is completed (output strings will be centralized in messages.rb files)…

  • Link: Shopify/shopify-app-cli #601


Shopify

  • Title: Janky UI when page is server side rendered with promoted filters

  • Description: When rendering a list page in the web admin using Filters and promoted filters, the UI ‘jumps’ after re-hydration…

  • Link: Shopify/polaris-react #2951


Google

  • Title: Fix color of status bar scrim

  • Description: The system inset areas shows as grey instead of blue in Offline areas and Settings…

  • Link: google/ground-android #490


executablebooks

  • Title: Incorrect initial permissions on example book

  • Description: The example book created by jupyter-book create creates files with permissions 775. None of these files are really executable, and therefore the correct permissions should be 664 (or probably 644)…

  • Link: executablebooks/jupyter-book #660


Grommet

  • Title: More theme support for customization of font family per component

  • Description: More components in the theme object should support customization by specifying a family property for those components. I was attempting to customize List while a coworker is trying to customize Anchor. Using the extend function is a workaround for now…

  • Link: grommet/grommet #4225


Thank you for your support.

Don't miss what's next. Subscribe to Good First Commit:
Powered by Buttondown, the easiest way to start and grow your newsletter.